Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web ui: renaming during deno publish UX #478

Closed
hashrock opened this issue May 3, 2024 · 1 comment · Fixed by #500
Closed

web ui: renaming during deno publish UX #478

hashrock opened this issue May 3, 2024 · 1 comment · Fixed by #500
Labels
bug Something isn't working good first issue Good for newcomers UI/UX

Comments

@hashrock
Copy link
Contributor

hashrock commented May 3, 2024 •
edited

When publishing with deno publish, if you rename with a text field in Publish a package form, The CLI becomes unable to proceed.
This is not a serious issue (UX), but it might confuse users, so it might be better to guide them in some way.

Step 1:

publish study-jsr-202305-rename module with deno publish

Step 2:

Rename the module with study-jsr-202305-rename-r1 on the text field

CleanShot 2024-05-03 at 10 21 11

Result:

CLI will be waiting forever

CleanShot 2024-05-03 at 10 21 31@2x

Workaround:

Interrupt the CLI, rewrite the name field in deno.json to study-jsr-202305-rename-r1, and re-run deno publish to be able to publish.
@hashrock hashrock changed the title web ui: renaming during publish UX web ui: renaming during deno publish UX May 3, 2024
@lucacasonato
Copy link
Member

We should prevent you from modifying inputs if you are coming from the CLI.

@lucacasonato lucacasonato added bug Something isn't working good first issue Good for newcomers UI/UX labels May 6, 2024
@lucacasonato lucacasonato mentioned this issue May 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 14, 2024
@lucacasonato
fix: disallow editing on the new page when coming from CLI (#500)
e243ea0 
![image](https://github.com/jsr-io/jsr/assets/7829205/44759e8d-4c6c-4e8d-8d82-03027a70e954)

Note how the "or create a new scope" text is gone, and how you can no
longer edit the text fields.

Fixes #478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers UI/UX
Projects
JSR
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disallow editing on the new page when coming from CLI jsr-io/jsr
2 participants
@hashrock @lucacasonato