Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup's bundling is very slow #16

Closed
jadeddelta opened this issue May 27, 2022 · 2 comments
Closed

Rollup's bundling is very slow #16

jadeddelta opened this issue May 27, 2022 · 2 comments
Labels
low priority Not necessary to work on now

Comments

@jadeddelta
Copy link
Contributor

Title. We have a simple build but a long compilation time, has been noted it could definitely be because of how big tensorflow is. Options suggested include bundling tfjs separately, downgrading either TS itself or the rollup TS plugin, attempting to use parcel again (or webpack!), and so on.

This isn't too much of an issue but just a place where if we have some free time and want to work on making developing this a bit more smooth, we can just go to here to see what works, what doesn't work, and discuss solutions.

Relevant articles:
Problem w/ TS, could try to downgrade?
An article with just some general thoughts on how to speed things up.

Things that don't work:
Setting commonjs({ sourceMap: false }) in rollup.config.js
Setting "declarations" : false" in tsconfig.json

@jadeddelta jadeddelta added the low priority Not necessary to work on now label May 27, 2022
@jadeddelta
Copy link
Contributor Author

Things to note: This might very well be a performance issue on the laptop end, but it manifests on an incredibly weird way.
My laptop (unplugged) - AMD Radeon 5900HS: ~20-21s build
My laptop (plugged) - AMD Radeon 5900HS w/ NVIDIA RTX 3060 GPU - ~7s build
Olir's laptop - M1 MacBook Air - ~7s build
Shunji's laptop - M1 MacBook Pro - ~4s build

??? Incredibly odd and I'm not sure why the GPU would bottleneck this performance, especially considering my laptop is pretty capable. Along with this, inspecting in task manager/just listening to how the fans don't even fire means that there's not even a large system load when this occurs.

@jadeddelta
Copy link
Contributor Author

Closing this issue as it seems that there's not really a fix for it, and from further examination of the time and me simply testing it shows vast inconsistencies, sometimes it's just much faster than the displayed 7-8 seconds. There's not really much else to do.

@jadeddelta jadeddelta closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Not necessary to work on now
Projects
None yet
Development

No branches or pull requests

1 participant