Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to readable-stream (?) #95

Open
relu91 opened this issue Mar 22, 2024 · 2 comments
Open

Upgrade to readable-stream (?) #95

relu91 opened this issue Mar 22, 2024 · 2 comments

Comments

@relu91
Copy link

relu91 commented Mar 22, 2024

Hi all, thank you for bundling together node polyfils for browsers. I'm using esbuild-plugin-polyfill-node and I'm using streams. I was wondering if upgrading the bundled browserify streams to official readable stream implementation is possible.

Browserify readable stream is stuck into 2020 and it does not have support for Readable.from function (because it refers to an old version of readable-stream package). The lastest version of readable-stream (v4.x.x) supports browsers and it is still actively maintained. I've already tried it in a bunch of projects with no side-effects.

@guybedford
Copy link
Member

I would be happy to update the readable stream polyfill implementation used in this project to a newer one. Do you have any suggestions what a good option might be at this point?

@relu91
Copy link
Author

relu91 commented Mar 27, 2024

Thank you for considering this option! As far I can tell https://github.com/nodejs/readable-stream?tab=readme-ov-file#readable-stream v4.x.y is already a good candidate for polyfill. I'm trying to bake a PR but it seems that just removing stream-browserify and add the new package cause the export test to fail. As far as I can tell it seems that it is not exporting anything.

If you don't mind I can open a draft PR and we can move the discussion there.

relu91 added a commit to relu91/jspm-core that referenced this issue May 27, 2024
removes browserify-stream with more recent and updated package
called readable-stream

fix jspm#95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants