-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to readable-stream (?) #95
Comments
I would be happy to update the readable stream polyfill implementation used in this project to a newer one. Do you have any suggestions what a good option might be at this point? |
Thank you for considering this option! As far I can tell https://github.com/nodejs/readable-stream?tab=readme-ov-file#readable-stream v4.x.y is already a good candidate for polyfill. I'm trying to bake a PR but it seems that just removing If you don't mind I can open a draft PR and we can move the discussion there. |
removes browserify-stream with more recent and updated package called readable-stream fix jspm#95
Hi all, thank you for bundling together node polyfils for browsers. I'm using esbuild-plugin-polyfill-node and I'm using streams. I was wondering if upgrading the bundled browserify streams to official readable stream implementation is possible.
Browserify readable stream is stuck into 2020 and it does not have support for
Readable.from
function (because it refers to an old version ofreadable-stream
package). The lastest version of readable-stream (v4.x.x) supports browsers and it is still actively maintained. I've already tried it in a bunch of projects with no side-effects.The text was updated successfully, but these errors were encountered: