Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jspm build: Make rollup configuration optional #2558

Open
guybedford opened this issue Dec 10, 2023 · 4 comments
Open

jspm build: Make rollup configuration optional #2558

guybedford opened this issue Dec 10, 2023 · 4 comments
Assignees

Comments

@guybedford
Copy link
Member

A standard rollup configuration shouldn't be provided by default without needing an explicit configuration file for simple build cases.

@guybedford guybedford changed the title Make rollup configuration optional jspm build: Make rollup configuration optional Dec 10, 2023
@JayaKrishnaNamburu
Copy link
Member

It's possible with the following commands without passing config.
https://codesandbox.io/p/devbox/jspm-build-n65wdt?file=%2F.codesandbox%2Ftasks.json%3A19%2C1

jspm build index.js --output build.js

@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Dec 11, 2023
@guybedford
Copy link
Member Author

Great, thanks for verifying. Is there anything else we need to do here then?

@JayaKrishnaNamburu
Copy link
Member

Maybe we can start supporting some of the config like inlineDynamicImports etc.
Eg: We can just use the command instead of passing rollup-config for vs-code extension.

Instead of passing config like this

jspm build -r @babel/helper-module-transforms=@babel/helper-module-transforms@7.21.2 --config rollup-config.mjs

it can become this

jspm build -r @babel/helper-module-transforms=@babel/helper-module-transforms@7.21.2 --inlineDynamicImports

But apart from that, the basic building and stuff are good.

@guybedford
Copy link
Member Author

Yes, like wrapping the Rollup CLI itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants