Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Export - picture does not render #541

Open
kmcquade opened this issue Mar 23, 2021 · 1 comment
Open

PDF Export - picture does not render #541

kmcquade opened this issue Mar 23, 2021 · 1 comment

Comments

@kmcquade
Copy link

kmcquade commented Mar 23, 2021

It looks like resume-cli is not rendering the picture - whether it is using a remote URL or a local path. See example below.

  • Resume:

https://gist.github.com/kmcquade/03fd06e5cd295df4d31cfb9c41dc77e8

  • Screenshot:

image

@michaellee8
Copy link

michaellee8 commented Jun 18, 2021

I understands the problem now, if you import any pictures or icons in a relative path, pdf generation is going to fail since resume-cli just use base64 encoded html content as the url https://github.com/jsonresume/resume-cli/blob/master/lib/export-resume.js#L77. Due to the way that different theme works, there are no way to fix it now since it is not possible for resume-cli to know where are those asset stored. The solution is to generate pdf via puppeteer by urself.

You may want to see my scripts here https://github.com/michaellee8/michaellee8/blob/master/scripts/resume/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants