Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable users to ask for support of specific themes #38

Open
levino opened this issue Nov 29, 2023 · 2 comments · Fixed by #37
Open

enable users to ask for support of specific themes #38

levino opened this issue Nov 29, 2023 · 2 comments · Fixed by #37

Comments

@levino
Copy link
Collaborator

levino commented Nov 29, 2023

Users might get errors when trying to render resumes with deprecated / removed themes. Currently they get a misleading error message, claiming that they mistyped their username but actually they just have to use another theme. We need to handle the missing theme error appropriately and show a useful error message.

A solution was proposed in #37 in combination with #36.
@levino
Copy link
Collaborator Author

levino commented Nov 29, 2023 •
edited

I think the problem is urgent but am not a big fan of the solution in #37. I would use "new issue templates" to enable users to create specific "theme request" issues. Will have a quick glance and report back.

@levino levino mentioned this issue Nov 29, 2023
Merged
@levino
Copy link
Collaborator Author

levino commented Nov 29, 2023

Created #39 with a issue template.

@levino levino mentioned this issue Nov 29, 2023
Merged
@thomasdavis thomasdavis reopened this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add a link to a github issue when themes are missing jsonresume/jsonresume.org
2 participants
@thomasdavis @levino