Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom headerPattern doesn't get picked up by changelog conventional-commit-parser #735

Open
NullDivision opened this issue Sep 15, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@NullDivision
Copy link

When using a custom header such as the one below setting a custom headerPattern value gets picked up correctly to determine what the new version should be but the changelog itself is not including the commit message.

"version": {
      "executor": "@jscutlery/semver:version",
      "options": {
        "preset": "conventional",
        "baseBranch": "main",
        "commitMessageFormat": "chore(${projectName}): release version ${version} [skip ci]",
        "commitParserOptions": {
          "headerPattern": "^(\\w*)\\(comp-(\\w*)\\)?\\: (.*)$"
        }
      }
    }

It looks like conventionalChangelog isn't taking into account the headerPattern when determining what to include in the changelog.

@nikbabchenko
Copy link

Noticed the same.

@edbzn edbzn added the bug Something isn't working label Oct 7, 2023
@edbzn edbzn added the help wanted Extra attention is needed label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants