Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

requireAlignedMultilineParams: new rule #1901

Closed

Conversation

JGulbronson
Copy link
Contributor

enforce indentation of parameters in multiline functions

Closes gh-1896
Fixes #1894

Currently, it seems there's a gap in jscs with enforcing parameter alignment. The closest rule I could find is validateAlignedFunctionParameters, though the name doesn't seem to be an accurate description of what it does, and it isn't very customizable. I'm proposing an additional rule, which, when used along with validateAlignedFunctionParameters would allow users greater control over the indentation of their code.

@JGulbronson JGulbronson changed the title requireAlignedMultilineParams requireAlignedMultilineParams: new rule Oct 20, 2015
@hzoo hzoo added this to the 2.4.0 milestone Oct 21, 2015
@JGulbronson
Copy link
Contributor Author

@hzoo I see you added the 2.4.0 milestone to this. What are the next steps I have to take to make sure it makes it in to that release?

@markelog
Copy link
Member

Coverage decreased (-0.01%) to 98.373%

Would you mind fixing that? You can check out the coverage by executing nm run coverage-html && open coverage.html command

* ##### Valid for `'firstParam'`
*
* ```js
* var test = function(one, two,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add invalid case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

@markelog markelog closed this in 2c8d58e Oct 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: requireAlignedMultilineParams
3 participants