Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSCS errors getting swallowed somewhere #107

Open
robations opened this issue Apr 13, 2016 · 6 comments
Open

JSCS errors getting swallowed somewhere #107

robations opened this issue Apr 13, 2016 · 6 comments

Comments

@robations
Copy link

I have a gulp task like this:

gulp.task("jscs", function () {
    gulp.src(["**/*.js"])
        .pipe(plugins.jscs())
        .pipe(plugins.jscs.reporter());
});

Depending on when errors are encountered they do not seem to be reported. For example, if I change the glob pattern to ["zzz/**/*.js", "{aaa,bbb,ccc}/**/*.js"] (in this example only the dir zzz contains errors), suddenly the reporter outputs errors.

It seems like the reporter somehow gets "saturated" with messages so I tried changing the maxErrors config for jscs but this didn't make a difference.

Installed versions:

├─┬ gulp-jscs@3.0.2
│ └─┬ jscs@2.11.0
@robations
Copy link
Author

This sounds a little like #42

@slavede
Copy link

slavede commented May 11, 2016

maxErrors config for jscs

Did you change that in your .jscsrc or in gulp call?

@robations
Copy link
Author

.jscsrc I think.

@slavede
Copy link

slavede commented May 11, 2016

Hmm....i had similar issue, but putting maxErros inside .jscsrc fixed it (I was trying to pass it as part of gulp-jscs option before)

@robations
Copy link
Author

I couldn't find any joy with it. As a workaround I added an npm build task, eg in package.json:

  "scripts": {
    "jscs": "jscs -v ./"
  }

Also considering eslint as an "extreme workaround" but I've moved onto a different project for the moment.

@slavede
Copy link

slavede commented May 11, 2016

@hzoo @markelog ...can you close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants