Maximum call stack size exceeded when related models have different idAttribute

[zuzusik]

Description

JSData gets into infinite loop when trying to add item together with its relations to the store when idAttribute fields of related models are different.

Environment

• js-data version: 3.0.8
• node or browser version: any
• operating system: any

Steps to reproduce

simple code to reproduce

const jsData = require('js-data');

const store = new jsData.DataStore();

store.defineMapper('user', {
  idAttribute: 'userId',
  relations: {
    hasOne: {
      profile: {
        foreignKey: 'user_id',
        localField: 'profile'
      }
    }
  }
});

store.defineMapper('profile', {
  idAttribute: 'profileId',
  relations: {
    belongsTo: {
      user: {
        foreignKey: 'user_id',
        localField: 'user'
      }
    }
  }
});

store.add('user', {
  userId: 1,
  profile: {
    profileId: 1,
    user_uid: 1
  }
})

Same code on RunKit: https://runkit.com/embed/frx2z0xbtijo

Possible Fix

As far as I see, there is an error on following line:

js-data/src/Relation.js

Line 163 in c068c4b

const relatedId = utils.get(relatedRecord, this.mapper.idAttribute)

Here this.mapper is not a mapper of relatedRecord, so taking it's idAttribute is not right.

Most likely, this line should be replaced with

const relatedId = this.relatedCollection.recordId(relatedRecord)

I will follow-up with a fix PR together with appropriate tests in upcoming days.