Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide opts input for commit() in js-data.d.ts #538

Open
zeesulehria opened this issue Apr 23, 2019 · 0 comments
Open

Provide opts input for commit() in js-data.d.ts #538

zeesulehria opened this issue Apr 23, 2019 · 0 comments

Comments

@zeesulehria
Copy link

Description

Currently we have this definition in js-data.d.ts file:
commit(): this
Whereas it needs to be:
commit(opts?): this

This is needed for example, if I need to commit a record with relations like: this.order.commit({with: this.order.relations})

Environment

  • js-data version: "js-data": "^3.0.5",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant