Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSSqlAdapter.filterQuery failure #75

Open
peteut opened this issue Sep 30, 2016 · 0 comments
Open

DSSqlAdapter.filterQuery failure #75

peteut opened this issue Sep 30, 2016 · 0 comments

Comments

@peteut
Copy link

peteut commented Sep 30, 2016

if (params instanceof Object.getPrototypeOf(this.query.client).QueryBuilder) {

should spell

if (params instanceof Object.getPrototypeOf(this.query.client).queryBuilder) {

Refer to knex source: client.js#L61 for reference.
node -v yields v4.6.0 and npm list | grep knex yields ├─┬ knex@0.12.0.
npm list | grep js-data yields

├── js-data@2.9.0
├─┬ js-data-sql@0.11.17 (git://github.com/peteut/js-data-sql.git#c94819ffdfa09d293a6acaeab6a2db496c7b1fac)

I was not able to run CI, therefore I could not prepare a pull request yet.

@peteut peteut changed the title Typo DSSqlAdapter.filterQuery failure Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant