Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios as devDependency #65

Open
oprogramador opened this issue Dec 21, 2016 · 4 comments
Open

axios as devDependency #65

oprogramador opened this issue Dec 21, 2016 · 4 comments
Assignees
Labels
Milestone

Comments

@oprogramador
Copy link

I noticed axios belongs here to devDependencies but IMO it's a prod dependency.

@Hagith
Copy link

Hagith commented Apr 13, 2017

Currently axios is bundled inside dist/*.js. Probably that's why listed only as a dev dependency.
IMHO axios should be peerDependency and not bundled into dist.

@oprogramador
Copy link
Author

oprogramador commented Apr 13, 2017

I consider axios as an implementation detail. It could be replaced by superagent or another library and behave in the same way.

So IMO it should be a prod dependency.

@jmdobry
Copy link
Member

jmdobry commented Jul 2, 2017

If you use js-data-http, then axios is bundled into dist/js-data-http.js. If you use js-data-fetch, axios is not bundled, and you need to provide an agent, such as superagent. If you use js-data-http-node, then axios is a prod dependency and will be installed and loaded by your app. I will add axios as a prod dependency of js-data-http.

@jmdobry jmdobry self-assigned this Jul 2, 2017
@jmdobry jmdobry added the bug label Jul 2, 2017
@jmdobry jmdobry added this to the 3.0 milestone Jul 2, 2017
@jmdobry jmdobry added the v3 label Jul 2, 2017
@chlab
Copy link

chlab commented Dec 1, 2017

I agree with @Hagith and think axios should be a peerDependency. If you're using js-data-http but are using axios in your app for other requests, would it then not end up being bundled twice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants