Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adapter): Prevent fetching belongs to when localKey is empty #13

Closed
wants to merge 1 commit into from
Closed

fix(adapter): Prevent fetching belongs to when localKey is empty #13

wants to merge 1 commit into from

Conversation

lusarz
Copy link

@lusarz lusarz commented Jun 24, 2018 •
edited

Fixes #11, fixes js-data/js-data#505

  • - npm test succeeds
  • - Code coverage does not decrease (if any source code was changed)
  • - Appropriate JSDoc comments were updated in source code (if applicable)
  • - Approprate changes to js-data.io docs have been suggested ("Suggest Edits" button)

@lusarz lusarz mentioned this pull request Jun 24, 2018
Open
@lusarz
Copy link
Author

lusarz commented Aug 20, 2018

@crobinson42
I think I need help to write unit tests for these changes. I'm not sure where to put them ...

@crobinson42
Copy link
Member

@lusarz I would suggest a new test is added to under this scope: https://github.com/js-data/js-data-adapter/blob/master/test/findAll.test.js#L126

@crobinson42
Copy link
Member

@lusarz bump

@lusarz lusarz closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lusarz @crobinson42