Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Icon? #54

Open
stefanor opened this issue Feb 20, 2018 · 4 comments
Open

An Icon? #54

stefanor opened this issue Feb 20, 2018 · 4 comments

Comments

@stefanor
Copy link
Contributor

Forwarded from: Debian #854131:

Hi,
The xdot package installs a xdot.desktop file but is not setting any icon.
Could you please provide an icon for the application?
Regrads,

I know you aren't shipping the desktop file, we are. But it would be nice if there was a project logo to use as the icon.

@jrfonseca
Copy link
Owner

I'd happily accept a patch, but besides the open issue of making/choosing an icons, I'm not familiar with the process of integrating and deploying icons, and I'm afraid this is not high enough in my priority list to go figure it out.

I googled for CC icons and these looks nice:

In short, if a charitable soul makes a pull request to add an icon, I'll happily merge it.

@jeremydouglass
Copy link

Not my area of expertise, but I don't think the xdot source is the place to add a Debian app icon. Instead, I think (?) you want to add it to the package:

...specifically, to the .desktop file, e.g. like in the discussion here:

@valpackett
Copy link

hi! The source is absolutely the right place. An icon belongs to the app, not to the distribution. (I'm currently updating the FreeBSD port, by the way.)

Here's a good example of installing icons, desktop files and other stuff with distutils: https://0xacab.org/mat/mat/blob/4b9a65758da4bb27724ac1f94162810a29cb3877/setup.py#L44-50

    data_files=[
        ('share/applications', ['mat.desktop']),
        ('share/mat', ['data/FORMATS', 'data/mat.glade']),
        ('share/pixmaps', ['data/mat.png']),
        ('share/doc/mat', ['README.md', 'README.security']),
        ('share/man/man1', ['mat.1', 'mat-gui.1']),
        ('share/nautilus-python/extensions', ['nautilus/nautilus-mat.py'])
    ],

(I would prefer share/icons/hicolor/{SIZE}/apps/ to the old share/pixmaps though, as some launchers like rofi (used to?) ignore pixmaps)

@stefanor
Copy link
Contributor Author

setuptools doesn't even have to do anything special with the icon. Just blessing a particular icon and shipping it in the tarball, would allow distros to do the right thing with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants