Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RadialSolver: Dynamic Liquid Layer Stability Issues #55

Open
jrenaud90 opened this issue Apr 26, 2024 · 1 comment
Open

RadialSolver: Dynamic Liquid Layer Stability Issues #55

jrenaud90 opened this issue Apr 26, 2024 · 1 comment
Labels
Performance Issue related to run time performance RadialSolver Research Needed Research is required to address this issue

Comments

@jrenaud90
Copy link
Owner

Describe the bug
This is a thread to track improvements / issues related to integration stability when using dynamic liquid layers in RadialSolver.

  • Causes
    • Stability problems appear when a dynamic liquid layer is present in a world with a moderately large forcing period.
    • The value of the forcing period depends on the density of the liquid. A low density liquid tends to be more stable at higher forcing periods than a high density layer.

Note that "forcing period" refers to the tidal mode that is being calculated. A planet with a low orbital period may still require larger forcing period modes depending on its eccentricity, obliquity, and rotation rate.

@jrenaud90 jrenaud90 added Research Needed Research is required to address this issue Performance Issue related to run time performance RadialSolver labels Apr 26, 2024
@jrenaud90
Copy link
Owner Author

The new RadialSolver has a warning when provided with a high forcing period and a liquid layer. Currently this warning does not check for the density of the layer.

It would be nice to come up with a stability term (function of frequency, density and ???) that can be used in these warning checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issue related to run time performance RadialSolver Research Needed Research is required to address this issue
Projects
None yet
Development

No branches or pull requests

1 participant