Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question of starting codition order TS72 vs. KMN15 #43

Open
jrenaud90 opened this issue Feb 5, 2024 · 1 comment
Open

Question of starting codition order TS72 vs. KMN15 #43

jrenaud90 opened this issue Feb 5, 2024 · 1 comment
Labels
Beginner Issue is good for newcomers to TidalPy Question Further information is requested

Comments

@jrenaud90
Copy link
Owner

Kamata et al. (2015) has the two starting solutions for RadialSolver k^2 +/- (see their Eq. B13) implying that solution 1 uses the + version and solution 2 uses the minus.

Takeuchi & Saito (1972) have similar starting solution definitions but order them as -/+ (see their Eq. 99).

TidalPy has the option to use both starting solutions. For Kamata we use +/- and for Takeuchi we use -/+. See the respective equations in "RadialSolver.starting".

@jrenaud90 jrenaud90 added the Question Further information is requested label Feb 5, 2024
@jrenaud90 jrenaud90 added the Beginner Issue is good for newcomers to TidalPy label Feb 5, 2024
@jrenaud90
Copy link
Owner Author

  • Check if this makes a difference to begin with (try flipping solution 1 and solution 2)
  • If it does then try to determine which is correct
  • Update code and TODOs for starting condition functions in "RadialSolver.strating"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner Issue is good for newcomers to TidalPy Question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant