Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLoating Point Issues in Takeuchi Starting Conditions #41

Open
jrenaud90 opened this issue Jan 31, 2024 · 0 comments
Open

FLoating Point Issues in Takeuchi Starting Conditions #41

jrenaud90 opened this issue Jan 31, 2024 · 0 comments

Comments

@jrenaud90
Copy link
Owner

An earlier version of TidalPy used the full definition of Takeuchi & Saito (1972)'s starting conditions in the radial function.
However, testing revealed that there were issues matching the limiting values (as z -> 0) since the full solution has terms that are like: (Very Big) / (Very Big) ~ near 1. Errors would compound leaving the final answer larger or smaller than 1.

Current Solution:
Have reverted back to using the limiting version of these equations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant