Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check so that andrade alpha stays between 0.0 and 1.0 #14

Closed
jrenaud90 opened this issue Jul 18, 2019 · 1 comment
Closed

Add a check so that andrade alpha stays between 0.0 and 1.0 #14

jrenaud90 opened this issue Jul 18, 2019 · 1 comment
Labels
Beginner Issue is good for newcomers to TidalPy Enhancement New feature or request Functional Issue with Functional Scheme

Comments

@jrenaud90
Copy link
Owner

The custom njit factorial function does not work outside this range. Physically that is fine since we do not expect alpha to be outside this range. However, the current code allows it to fall outside this range.
@jrenaud90 jrenaud90 added Enhancement New feature or request Functional Issue with Functional Scheme Beginner Issue is good for newcomers to TidalPy labels Jul 18, 2019
@jrenaud90
Copy link
Owner Author

This is no longer an issue with the new rheology functions introduced in v0.5.0+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Issue is good for newcomers to TidalPy Enhancement New feature or request Functional Issue with Functional Scheme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrenaud90