[packagers] asdf publisher reports success even if commit isn't pushed

[haydenbaker]

TLDR

If a PAT used for a release doesn't have the right scopes, certain git operations may fail, but JReleaser does not fail when it should.

Task List

• Steps to reproduce provided
• Stacktrace (if present) provided
• Example that reproduces the problem (link to git repository is ideal)
• Full description of the issue provided (see below)

Steps to Reproduce

• Set up an empty asdf repo for the asdf scripts (or in my case an already existing repo made by hand)
• Set up release with an asdf publisher
• Create a PAT without the workflow scope, but with repo scope
• Run the full release
• Observe that success is reported and that the log doesn't contain an error:

[INFO]      [asdf] pushing to haydenbaker/asdf-smithy
[DEBUG]     [asdf] pushing commit to remote

• Observe repo doesn't have the release commit

Expected Behaviour

• JReleaser should fail when a release commit doesn't actually get pushed

Actual Behaviour

• No errors are reported, and commit is not actually pushed

Environment Information

• Operating System: MacOS Ventura 13.6
• JReleaser Version: Latest
• JDK Version: 17

Please paste stacktraces from [out|build|target]/jreleaser/trace.log.
N/A, no traces observed. HOWEVER, I only discovered the fix when running the release with debug logs (gradle):

2024-01-30T11:32:21.784-0800 [DEBUG] [org.eclipse.jgit.transport.PacketLineIn] git< unpack ok
2024-01-30T11:32:21.784-0800 [DEBUG] [org.eclipse.jgit.transport.PacketLineIn] git< ng refs/heads/main refusing to allow a Personal Access Token to create or update workflow `.github/workflows/build.yml` without `workflow` scope

I'd assume this affects other publishers as well, but haven't tried it.

[aalmiray]

There might be an exception that's being swallowed or incorrect handling of an HTTP error.

[aalmiray]

I would have expected an error to occur at

jreleaser/core/jreleaser-engine/src/main/java/org/jreleaser/packagers/AbstractRepositoryPackagerProcessor.java

Lines 165 to 170 in 853d293

	git.push()
	.setDryRun(false)
	.setPushAll()
	.setCredentialsProvider(credentialsProvider)
	.setPushTags()
	.call();

but it does not. I'm able to reproduce the problem.

I wonder if this has been fixed in a later version of JGit (6.x) in which case we must pause the upgrade til JReleaser switches its baseline to Java 11 as a minimum.

[aalmiray]

Follow up at https://www.eclipse.org/forums/index.php/m/1863549/#msg_1863549