[plugin] Gradle plugin unconditionally assumes that a clean tasks exists

[sschuberth]

In

jreleaser/plugins/jreleaser-gradle-plugin/src/main/groovy/org/jreleaser/gradle/plugin/internal/JReleaserProjectConfigurer.groovy

Lines 78 to 88 in e4a487d

	project.tasks.named('clean', new Action<Task>() {
	@Override
	void execute(Task t) {
	t.doFirst(new Action<Task>() {
	@Override
	void execute(Task task) {
	loggerProvider.get().close()
	}
	})
	}
	})

a cleantask is (re-)configured to close the logger. However, when applying the JReleaser plugin (for ChangeLog generation only) to the root project (of a multi-project with multiple application projects), no clean task exists.

Is this code even legit? Why should the logger (only) be closed if the clean task is executed?

[aalmiray]

a cleantask is (re-)configured to close the logger. However, when applying the JReleaser plugin (for ChangeLog generation only) to the root project (of a multi-project with multiple application projects), no clean task exists.

The current expectation is to have a clean task available. I was under the impression such task is always there as it's very likely that a root project includes a base plugin that provides the task, even if the root has no sources at all.

Is this code even legit?

I don't know what you were expecting to gain with this remark.

Why should the logger (only) be closed if the clean task is executed?

More context #1074

#1292

[sschuberth]

I was under the impression such task is always there as it's very likely that a root project includes a base plugin that provides the task, even if the root has no sources at all.

Well, all I can say is that in a build file like this no clean task is available.

I don't know what you were expecting to gain with this remark.

I was simply wondering whether, instead of fixing the code to not assume the clean task to exist, the code could simply be removed.

More context #1074

Thanks.

[aalmiray]

I was simply wondering whether, instead of fixing the code to not assume the clean task to exist, the code could simply be removed.

Then I'd suggest you lead with more explanation as you just did instead of what you wrote on the first message.

Clarity always wins.

[aalmiray]

And no, the code cannot be removed. The logger must be closed no matter what otherwise a file descriptor will be left open on Windows, leading to other problems.

What could happen is adding a check for the existence of a clean tasks but IIRC that is what the Gradle API offers by registering a lazy action matching tasks by name.