Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS 2 Item Author element totally wrong #141

Open
paul-uz opened this issue Feb 17, 2021 · 5 comments
Open

RSS 2 Item Author element totally wrong #141

paul-uz opened this issue Feb 17, 2021 · 5 comments

Comments

@paul-uz
Copy link

paul-uz commented Feb 17, 2021

As per the RSS2 spec

<author> is an optional sub-element of <item>.

It's the email address of the author of the item. For newspapers and magazines syndicating via RSS, the author is the person who wrote the article that the <item> describes. For collaborative weblogs, the author of the item might be different from the managing editor or webmaster. For a weblog authored by a single individual it would make sense to omit the <author> element.

<author>lawyer@boyer.net (Lawyer Boyer)</author>

Currently, this package defines an Author object with an optional name, email and link. If anything, email should be required. Link is not needed.

The current implementation is broken and does not correctly adhere to RSS 2.0.

@jooola
Copy link
Contributor

jooola commented May 24, 2021

The tricky thing is that this package tries to wrap RSS2, Atom and JSON Feed using a single Feed Options schema. And all these specs doesn't match in every way.

I suggest you don't rely on the type definition to know if it adhere to the specs.

Additionally, we could provide a StrictFeedOptions that only allow undefined properties on fields that are not required in the 3 different specs.

@paul-uz
Copy link
Author

paul-uz commented May 25, 2021

@jooola in that caase, this library should provide schemas for each feed type, or remove all assumptions eg the author issue I outlined.

@jooola
Copy link
Contributor

jooola commented May 25, 2021

I agree.

This is also a blocker for me. I might try the enhance this library. But I need @jpmonette around in order to merge these enhancements.

@swilgosz
Copy link

swilgosz commented Jul 5, 2021

Any update on this? Do you need a help?

@GavanWilhite
Copy link

GavanWilhite commented Dec 17, 2022

Is there any way to JUST have the email listed in the author field? I've tried setting the name field to null or undefined, but then it won't render any tag. If you have anything or an empty string it will render "email@email.com ()"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants