Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwing exception if elem is undefined #128

Open
nstmzn opened this issue Sep 19, 2019 · 0 comments
Open

Throwing exception if elem is undefined #128

nstmzn opened this issue Sep 19, 2019 · 0 comments

Comments

@nstmzn
Copy link

nstmzn commented Sep 19, 2019

notifyjs/dist/notify.js

Line 539 in 7191c17

if ((elem && elem.nodeName) || elem.jquery) {

Current code-
$[pluginName] = function(elem, data, options) {
if ((elem && elem.nodeName) || elem.jquery) {

Looks like above line of code is missing undefined check in OR condition.

Proposed solution-
if ((elem && elem.nodeName) || (elem &&elem.jquery) ) {
Aldo-f added a commit to Aldo-f/notifyjs that referenced this issue Feb 9, 2023
@Aldo-f
Update notify.js
12f6a14 
jpillora#128
Aldo-f added a commit to Aldo-f/notifyjs that referenced this issue Feb 9, 2023
@Aldo-f
Update notify.js
c89a7b1 
jpillora#128
@Aldo-f Aldo-f mentioned this issue Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nstmzn