Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ChunkGenerateEvent-like rendering behavior for pre-generated maps #97

Open
jpenilla opened this issue Apr 8, 2023 · 0 comments
Open
Labels
accepted Issue has been accepted as valid/Feature request has been accepted and is planned to be implemented enhancement New feature or request

Comments

@jpenilla
Copy link
Owner

jpenilla commented Apr 8, 2023

Basically, the goal is to allow behavior how you would get without a pre-generated map and ChunkGenerateEvent, where chunks render once a player goes near them; but with a pre-generated map and without the performance penalty of the current PlayerChunkLoadEvent option (which would be the current workaround to accomplish this, and will cause lots of unnecessary renders).

To implement this we want to add a new map update listener "player map discovery" or something, which will queue chunks for render on player chunk load, give the chunk a persistent marker that it's "discovered", and then ignore any "discovered" chunks in future player load events. We could also go further and ignore non-discovered chunks in other update listeners, but that can be considered after the base feature is implemented.

@jpenilla jpenilla added enhancement New feature or request accepted Issue has been accepted as valid/Feature request has been accepted and is planned to be implemented labels Apr 8, 2023
@jpenilla jpenilla changed the title Option to not count chunks as generated for rendering until "discovered" by a player Allow ChunkGenerateEvent-like rendering behavior for pre-generated maps Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted as valid/Feature request has been accepted and is planned to be implemented enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant