Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db/insert tries to make a parameter for db/table when params has no table name #89

Open
LeviSchuck opened this issue Apr 27, 2021 · 4 comments

Comments

@LeviSchuck
Copy link

While following example code in the authentication docs

It appears that it is attempting to run the following sql

insert into account (password, db/table, email) values (?, ?, ?);

With the params being set to.

@{:db/table @{:keys (:email :password) :required true} :email "example@example.com" :password "....."}

I've tracked this down in the code.. it seems that params will accept input without a table

(def params
  (params # nothing here
    (validates [:email :password] :required true)
    (permit [:email :password])))

while later in the request

(params ?)
(hash-password ?)
(db/insert :account ?)

The correct way of doing things seems to be

(def params
  (params :account
    (validates [:email :password] :required true)
    (permit [:email :password])))
(params ?)
(hash-password ?)
(db/insert ?) # No longer include the table name

It was really confusing to get an error like invalid syntax around /, which required hacking in printf's to find the cause.

@swlkr
Copy link
Collaborator

swlkr commented Apr 27, 2021

Ah yes, this should definitely throw an error from params, and the docs should be clearer.

Seems like you’re the first one to use joy pretty extensively haha

@LeviSchuck
Copy link
Author

Seeing https://news.ycombinator.com/item?id=23046568 On HN is what brought me to Janet.

I just could never write the application I wanted to until I had cryptography primitives.

@LeviSchuck
Copy link
Author

I've put up an example project that incorporates the authentication doc material.

There are syntactic problems too that have been resolved in this https://github.com/LeviSchuck/joy-example-auth

@swlkr
Copy link
Collaborator

swlkr commented Apr 30, 2021

I updated the authentication docs for now, but I think I need a whole new docs section on params and what it does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants