Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require package-lock.json #1527

Open
1 of 4 tasks
jakelevi opened this issue Feb 8, 2023 · 1 comment
Open
1 of 4 tasks

Don't require package-lock.json #1527

jakelevi opened this issue Feb 8, 2023 · 1 comment
Labels

Comments

@jakelevi
Copy link

jakelevi commented Feb 8, 2023

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Expected Behavior

Being able to run jovo CLI commands without having a package-lock.json

Current Behavior

Through some digging, we realized that there's checks for package-lock.json. So it keeps throwing:

To use this command, please go into the directory of a valid Jovo project.

Our project doesn't need a package-lock.json

I feel like these checks are unnecessary.

Error Log

To use this command, please go into the directory of a valid Jovo project.

Your Environment

  • Jovo Framework version used: 3.6.2
  • Operating System: macOS 13.0.1
@aswetlow
Copy link
Member

aswetlow commented Feb 9, 2023

Hey @jakelevi

I tried it with jovo v4 and jovo v3, but I can't reproduce it.

$ jovo3 new foobar
$ cd foobar
$ rm ./package-lock.json
$ jovo3 run

Do you have an example?

@jankoenig jankoenig added the v3 label Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants