Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling "jovo build --clean" should NOT delete tasks folder #158

Open
1 of 4 tasks
rmtuckerphx opened this issue Jul 31, 2020 · 5 comments
Open
1 of 4 tasks

Calling "jovo build --clean" should NOT delete tasks folder #158

rmtuckerphx opened this issue Jul 31, 2020 · 5 comments
Labels
Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. Question/Discussion

Comments

@rmtuckerphx
Copy link
Contributor

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request
  • Other... Please describe:

Expected Behavior

Creating Custom Tasks for Alexa requires a tasks folder at platforms\alexaSkill\skill-package\tasks that contains task definition files. Calling --clean should not remove that folder or should make a backup copy first in a .clean folder.

Current Behavior

Calling $ jovo build --clean deletes the entire folder and the tasks contains task definition files that don't exist anyplace else so they can be lost.

Error log

None

Your Environment

  • Jovo CLI version used: 3.0.21
  • Operating System: Windows 10
@jankoenig
Copy link
Member

Hi @rmtuckerphx,

Thank you for the suggestion. Although I understand where you're coming from, I think introducing a feature like this would be inconsistent behavior as the --clean flag should always delete the complete folder and create it with completely fresh content.

As a workaround, would it make sense to store your custom tasks in a separate folder outside the platforms folder and copy them into the folder (e.g. with a script) after running jovo build?

@rmtuckerphx
Copy link
Contributor Author

The more I think about it, I like the idea of creating a backup folder and every time --clean is run a new folder based on datetime is created and the old folder is copied into it. Then the delete of the folder happens.

@rubenaeg
Copy link
Contributor

Hey @rmtuckerphx , what's your thinking behind this? Would you want to exit the task midthrough, before it deleting the old folder?

@rmtuckerphx
Copy link
Contributor Author

I just know that Amazon is putting more things in the platforms\alexaSkill\skill-package folder. So, maybe the skill.json file should be the only one deleted from there.

@rubenaeg
Copy link
Contributor

rubenaeg commented Oct 7, 2020

Hm, this would be very inconsistent behaviour in my opinion, a better approach would be to support task generation.

@rubenaeg rubenaeg added the Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Amazon Alexa Issues/PRs regarding Amazon Alexa functionality. Question/Discussion
Projects
None yet
Development

No branches or pull requests

3 participants