Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when fit!-ing a Group to a NamedTuple, the names are ignored #278

Open
schlichtanders opened this issue Mar 8, 2024 · 2 comments
Open

Comments

@schlichtanders
Copy link

schlichtanders commented Mar 8, 2024

using OnlineStats
o = Group(hi = Mean(), b = Counter())
fit!(o, [(b = 5, hi = 1)])

returns

Group
├─ Mean: n=1 | value=5.0
└─ Counter: n=1 | value=1

This is very confusing. If names are given on both sides, on definition of the Monoid and on the data, then it is at least for me intuitive if the data would be matched to the aggregators by names.

@joshday
Copy link
Owner

joshday commented Mar 8, 2024

fit!-ing is based on iteration: https://joshday.github.io/OnlineStats.jl/latest/howfitworks/

This is a good "OnlineStats 2.0" feature, but probably too much of a breaking change for now.

@schlichtanders
Copy link
Author

I guess the breaking part is that currently using entirely different keys still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants