Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require path in UseGraphiQl to be absolute #21

Open
FrankyBoy opened this issue Aug 7, 2018 · 4 comments
Open

Don't require path in UseGraphiQl to be absolute #21

FrankyBoy opened this issue Aug 7, 2018 · 4 comments

Comments

@FrankyBoy
Copy link
Contributor

Hi!

TL;DR: we are hosting in a subdirectory (to separate different API versions). Right now we have to call https://github.com/JosephWoodward/graphiql-dotnet/blob/6ff32fb21be3fb30c981d3d0e1dcff06e03811ff/src/graphiql/GraphiQlExtensions.cs#L16 with an absolute path, meaning we have to know the subdirectory we are hosted under. I would argue removing the check on this line https://github.com/JosephWoodward/graphiql-dotnet/blob/6ff32fb21be3fb30c981d3d0e1dcff06e03811ff/src/graphiql/GraphiQlExtensions.cs#L21 does not hurt anyone and gives more flexibility.

Cheers,
FB

FrankyBoy added a commit to FrankyBoy/graphiql-dotnet that referenced this issue Aug 7, 2018
SetPath needs to be checked. From what I can see it feeds into FileServerOptions which is passed to UseFileServer method at line 45.
@josephwoodward
Copy link
Owner

Sounds like a good idea, if you want to create a PR for your proposed fix then I can get it merged. I'll be doing a release in the next few days which also includes #15.

@FrankyBoy
Copy link
Contributor Author

Cool. Great news. Created a PR (#22) I hope that works out alright.

@josephwoodward
Copy link
Owner

Thanks!

@srini85
Copy link

srini85 commented Aug 10, 2018

Thanks guys. Great progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants