Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sacramento r #123

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Sacramento r #123

wants to merge 22 commits into from

Conversation

josephguillaume
Copy link
Collaborator

R implementation of sacramento by Anshika Shristi

josephguillaume and others added 22 commits June 26, 2020 15:45
@josephguillaume
fland1 R implementation from Anshika Shristi
333f477
@josephguillaume
Fix -> to $
6a4bce2
@AnshikaShristi
Merge pull request #1 from josephguillaume/fland1
999f3cc 
Fland1
@AnshikaShristi
-> changed to $
280c2b0
Merge branch 'master' of https://github.com/AnshikaShristi/hydromad
1d38c83
@josephguillaume
Merge pull request #79 from AnshikaShristi/master
b23fc01 
Working fland1
@josephguillaume
Reformat fland1 and return sma and fsum1
2280304
@josephguillaume
Reformat sacramento.R and add placeholders for for loop
0ed9499
@josephguillaume
Fix deprecation errors in test-sma-sim
99510fc
@AnshikaShristi
Merge pull request #2 from josephguillaume/fland1
a636ce9 
Template for Sacramento.R
introduced sma, fsum and for loop
dfb705f
@AnshikaShristi @josephguillaume
Update R/sacramento.R
b5d1de6 
Co-authored-by: Joseph Guillaume <josephguillaume@gmail.com>
@AnshikaShristi @josephguillaume
Update R/sacramento.R
cbd25b6 
Co-authored-by: Joseph Guillaume <josephguillaume@gmail.com>
@AnshikaShristi @josephguillaume
Update R/sacramento.R
c948e6a 
Co-authored-by: Joseph Guillaume <josephguillaume@gmail.com>
updated fsum1
ae22461
updated sma from fland1
8bb8ab6
@AnshikaShristi
used coredata
1d6ea13
@AnshikaShristi
Errors of {} rectified
4846e11
@AnshikaShristi
Comments added
cbb9bbb
@AnshikaShristi
included return state part
dbeb6ff
@josephguillaume
Return state as zooreg
082a0ac
@josephguillaume
Merge branch 'master' into sacramento_R
f3fef3f
@josephguillaume josephguillaume mentioned this pull request Jul 12, 2020
Closed
18 tasks
@josephguillaume
Copy link
Collaborator Author

Small differences between R and C versions found...

  • x not equal to expected.
    Mean relative difference: 0.001979361
  • x not equal to expected.
    Mean relative difference: 0.01910632
  • x not equal to expected.
    Mean relative difference: 0.001443368
  • argument is of length zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephguillaume @AnshikaShristi