Help with ESLint diagnostics

[onosendi]

Doesn't work in a TypeScript project. Once I comment out the commented lines, it works.

{
    "env": {
        "browser": true,
        "es2021": true
    },
    "extends": [
        "plugin:react/recommended",
        "airbnb",
        // "airbnb-typescript"
    ],
    // "parser": "@typescript-eslint/parser",
    "parserOptions": {
        "ecmaFeatures": {
            "jsx": true
        },
        "ecmaVersion": 12,
        "project": "./tsconfig.json",
        "sourceType": "module"
    },
    "plugins": [
        "react",
        "@typescript-eslint"
    ],
    "rules": {
        "no-param-reassign": "off",
        "react/react-in-jsx-scope": "off",
        "react/jsx-props-no-spreading": "off",
        "react/require-default-props": "off"
    }
}

[jose-elias-alvarez]

If modifying your ESLint config fixes the issue, it's most likely related to ESLint itself. Does everything work when you run eslint from the command line? If not, could you enable debug mode for null-ls and post the output?

[onosendi]

Below is my directory tree, and my null-ls.log. It seems the error has to do with null-ls not being able to find tsconfig.json in my root directory. What's weird though, is if I nvim client/src/Foo.tsx it works, but if I nvim server/src/index.ts it doesn't. I'm not quite sure how the internals of null-ls works, but if I had to guess I'd say it has to do with the location of my .git directory, because if I: git init server && nvim server/src/index.ts it works. What are my options to fix this behavior?

Directory tree:

├── .git
├── client
    ├── .eslintrc.json
    ├── .tsconfig.json
    ├── src
    │   ├── Foo.tsx
└── server
    ├── .eslintrc.json
    ├── .tsconfig.json
    ├── src
    │   ├── index.ts

null-ls.log:

received LSP request for method initialize
received LSP notification for method initialized
received LSP notification for method textDocument/didOpen
running generators for method NULL_LS_DIAGNOSTICS
spawning command eslint_d with args:
{ "-f", "json", "--stdin", "--stdin-filename", "/home/onosendi/repos/product-feedback/server/src/index.ts" }
error output: nil
output: [{"filePath":"/home/onosendi/repos/product-feedback/server/src/index.ts","messages":[{"ruleId":null,"fatal":true,"severity":2,"message":"Parsing error: Cannot read file '/home/onosendi/repos/product-feedback/tsconfig.json'."}],"errorCount":1,"fatalErrorCount":1,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"source":"...","usedDeprecatedRules":[{"ruleId":"lines-around-directive","replacedBy":["padding-line-between-statements"]},{"ruleId":"no-spaced-func","replacedBy":["func-call-spacing"]},{"ruleId":"global-require","replacedBy":[]},{"ruleId":"no-buffer-constructor","replacedBy":[]},{"ruleId":"no-new-require","replacedBy":[]},{"ruleId":"no-path-concat","replacedBy":[]}]}]

received diagnostics from generators
{}

[jose-elias-alvarez]

Your guess is correct. null-ls uses .git as a root pattern marker and uses that as its cwd when spawning processes. In this case ESLint isn't smart enough to search for tsconfig.json upwards from the current file's path, so it errors out when it can't find one at the root.

I tried setting up a similar structure locally, and I think we can solve this with the new cwd option that was just added to null-ls:

on_attach = function(client, bufnr)
    require("nvim-lsp-ts-utils").setup({
        eslint_opts = {
            cwd = function(params)
                return require("lspconfig.util").root_pattern("tsconfig.json")(params.bufname)
            end,
        },
    })
end

Can you update to the latest version of null-ls and see if that works?

[onosendi]

Same error as before. Here are the relevant configs:

https://github.com/onosendi/global-dotfiles/blob/master/.config/nvim/lua/plugins/nvim-lspconfig/tsserver.lua
https://github.com/onosendi/global-dotfiles/blob/master/.config/nvim/lua/plugins/nvim-lspconfig/null-ls.lua

[jose-elias-alvarez]

I see that you're registering the null-ls source separately. In that case, could you try this?

local null_ls_sources = {
    null_ls.builtins.diagnostics.eslint_d.with({
        cwd = function(params)
            return require("lspconfig.util").root_pattern("tsconfig.json")(params.bufname)
        end,
    }),
}
null_ls.register({ sources = null_ls_sources })

And since you're using eslint_d, I also recommend running eslint_d stop from the command line before opening Neovim again just to prevent any errors.

[onosendi]

Fixed. I can't thank you enough.