Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve quantileSeq typings #3198

Merged
merged 3 commits into from May 16, 2024
Merged

Improve quantileSeq typings #3198

merged 3 commits into from May 16, 2024

Conversation

domdomegg
Copy link
Contributor

Fixes #3197

josdejong
josdejong reviewed May 8, 2024
View reviewed changes
Copy link
Owner

@josdejong josdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam! I made two inline comments, can you have a look at those?

types/index.d.ts Outdated Show resolved Hide resolved
types/index.d.ts Show resolved Hide resolved
@josdejong
Copy link
Owner

Thanks for the updates, this looks good.

I see the build is still throwing 1 TypeScript error:

Error: test/typescript-tests/testTypes.ts(2539,10): error TS2554: Expected 2-3 arguments, but got 1.

Can you resolve that? I think you have to specify a probability in the test on that line. Besides that all is ready to merge.

@domdomegg
Copy link
Contributor Author

Whoops, missed that! Thanks for flagging, npm run test:types should now work (didn't realise this wasn't run by npm test).

@josdejong josdejong merged commit ffa3a2e into josdejong:develop May 16, 2024
7 checks passed
@josdejong
Copy link
Owner

Thanks. Good point about documentation missing on how to run these tests. I've added that via 49df889.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josdejong josdejong josdejong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

types: quantileSeq expands types unnecessarily
2 participants
@domdomegg @josdejong