Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better approach to test time plotters #16

Open
jorgepiloto opened this issue May 18, 2021 · 0 comments
Open

Find a better approach to test time plotters #16

jorgepiloto opened this issue May 18, 2021 · 0 comments
Labels
maintenance Generic maintenance related plotting Plotting and graphical utilities
Milestone

Comments

@jorgepiloto
Copy link
Owner

馃捇 Feature request: properly test time plotters

After merging #13, I was surprised about CI, as it did not complain about the output figures. Well, it turns out that the tests were not being properly executed... The command to run the images is tox -e py3X-images not tox -e py3X!

The time plotters are very susceptible to machine processes and other sources of error which can slightly affect the final output. That is why we provide a N_samples, so the problem is computed several times and the final mean values are taken as the "ideal" ones.

As opposite to the time plotters, the number of iterations ones always return the same input, as they only depend on the initial conditions. These are tested using the pytest-mpl plugin.

Therefore, we must find a proper way to test time plotters in order to not lose code coverage.

@jorgepiloto jorgepiloto added the maintenance Generic maintenance related label May 18, 2021
@jorgepiloto jorgepiloto added this to the 0.2 milestone May 18, 2021
@jorgepiloto jorgepiloto modified the milestones: 0.2, 0.3 Sep 6, 2021
@jorgepiloto jorgepiloto added the plotting Plotting and graphical utilities label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance related plotting Plotting and graphical utilities
Projects
None yet
Development

No branches or pull requests

1 participant