Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks Notification #913

Open
marcellogalhardo opened this issue Oct 1, 2023 · 0 comments
Open

Bookmarks Notification #913

marcellogalhardo opened this issue Oct 1, 2023 · 0 comments
Assignees

Comments

@marcellogalhardo
Copy link
Contributor

marcellogalhardo commented Oct 1, 2023

We should refactor the bookmarks notifications to use AlarmManager.

The current implementation uses Work Manager. It is not ideal for triggering precise notifications, and users may miss the bookmarked talk during an event.

Additionally, we will need:

  1. Handle Notification Permissions: https://developer.android.com/develop/ui/views/notifications/notification-permission#:~:text=If%20a%20user%20installs%20your,that%20permission%20to%20your%20app
  2. Handle AlarmManager permission: https://developer.android.com/training/scheduling/alarms

Those two points need to be addressed before removing the experimental feature flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant