Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning Issues for RNGoogleSignInEvents and RNGoogleSignIn #92

Open
eggybot opened this issue Jun 7, 2018 · 5 comments
Open

Warning Issues for RNGoogleSignInEvents and RNGoogleSignIn #92

eggybot opened this issue Jun 7, 2018 · 5 comments

Comments

@eggybot
Copy link

eggybot commented Jun 7, 2018

Module RNGoogleSignIn requires main queue setup since it overrides `constantsToExport` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.
Module RNGoogleSignInEvents requires main queue setup since it overrides `init` but doesn't implement `requiresMainQueueSetup`. In a future release React Native will default to initializing all native modules on a background thread unless explicitly opted-out of.

Hi I got this warning issue on RN iOS v0.53,0.54,0.55 , the login works fine but it shows some warning. Do we need to update the library to be able to comply with this yellow warnings?

thanks,

@sturmenta
Copy link

+1 "react-native": "0.56.0"

@xuyendtk95
Copy link

I has same issue

@TechDIY
Copy link

TechDIY commented Jul 19, 2018

insert this code in RNGoogleSignin.m

+(BOOL)requiresMainQueueSetup
{
return YES;
}

Hope it help you

@adcuz
Copy link

adcuz commented Aug 23, 2018

Same issue on RN 0.56, I'm not sure what the fix is to do a PR.

EDIT: Looks like someone has already submitted a PR in Dec, possible to get it merged? #64

@adcuz
Copy link

adcuz commented Sep 3, 2018

The original lib is now back in active development and the issue described here is no longer happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants