Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with documentation / conflict with react-native-firebase #73

Open
YGKtech opened this issue Feb 8, 2018 · 3 comments
Open

issue with documentation / conflict with react-native-firebase #73

YGKtech opened this issue Feb 8, 2018 · 3 comments

Comments

@YGKtech
Copy link

YGKtech commented Feb 8, 2018

Following the instructions from this repo when you already have react-native-firebase set up for authentication will lead to compiler errors (duplicate symbols, this project and rn-firebase depend on some of the same library's, but install them in different ways).

After digging around in the closed issues for this repo, I found someone mention that they resolved this by installing the native GoogleSignIn SDK using pods, rather than adding it manually as your instructions clearly specify. I tested it out, and was immediately successful.

From what I can tell, the current instructions will work as long as you don't have any dependencies installed via Pods. But the specific instructions to avoid using pods are problematic. Clearly this library CAN work when installing the SDK via pods, you may just need to copy some of the set up steps from react-native-firebase, and not using pods makes this library useless for firebase backed projects, which is a bit of a problem considering that firebase is one of the main use cases for google sign in now.

@eggybot
Copy link

eggybot commented Feb 10, 2018

I do agree on you, I'm using this setup along with my project with react-native-firebase , on Android setup there is no issue on setup but on iOS there are issue if you follow the instruction but I manage to properly work both modules to work out for iOS. I just forgot the steps I did but if I setup a new project I will list down all the steps I did and will share it here.

@calvinkei
Copy link

@YGKtech Spent a whole day on this, thanks for help. Would you mind making a PR on README?

@pdavid0
Copy link

pdavid0 commented Feb 25, 2018

I had the same issue, it wasn't building, only showing a huge list of errors "200 duplicate symbols".

Digging around I found this :

SO: Duplicate symbols when integrating Firebase and Google Sign In SDKs manually without Cocoapods

GIST: Script to build a new Google Sign in dependencies that will work with Firebase

My issue was apparently that Firebase includes the same files used in GoogleSignInDependencies.framework.

So you can either hack it with de script or go with the Pod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants