Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Hebrew randomize #21

Open
netroad opened this issue Jan 28, 2019 · 5 comments
Open

Adding Hebrew randomize #21

netroad opened this issue Jan 28, 2019 · 5 comments

Comments

@netroad
Copy link

netroad commented Jan 28, 2019

I use randomatic at work and i add locally to my project a option to randomize hebrew characters
Do you interesting in something like that in your code?

@doowb
Copy link
Collaborator

doowb commented Jan 28, 2019

Hi @netroad, thanks for opening an issue to discuss before submitting a PR. I like the idea, but I think using the chars option is a better way to use randomatic for this case. This lets anyone use any alphabet they'd like.

That being said, if you'd like to submit a PR to alphabet with changes to allow different alphabets and include Hebrew, that would be awesome!

Then if you wanted to submit an example showing how to use the alphabet library with randomatic that would be even better 😀

@netroad
Copy link
Author

netroad commented Jan 28, 2019

The thing is that Hebrew letters dont use upper and or lower case

@netroad
Copy link
Author

netroad commented Jan 28, 2019

Hebrew its a little tricky for working in this but i have an idea of hos to make it work
If you interesting i can dm you and we can talk about that

@doowb
Copy link
Collaborator

doowb commented Jan 28, 2019

If you interesting i can dm you and we can talk about that

I'm not familiar with Hebrew (but I'm happy to learn) so if you have ideas, please post them here. I'd rather keep the conversation open so anyone can contribute. Also, I might not be able to respond quickly right now, so someone else might be able to jump in.

@netroad
Copy link
Author

netroad commented Jan 28, 2019

Ok so the two main things about hebrew is

  1. is writing from right to left
    2)we have ends letters, basically some letter have a "second form" that is used in the end of words
    Now i think that maybe there will be a json document that include the line "left to right" and the value true or false and whenever the value is false it will whenever you call the rendomize function "break" the string and put it the other way and for the end letters, whenever you wil randomize them with other chars it will randomize it without the end letter and will put it at the end of the string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants