Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly & Monthly Streaks? #11

Open
oyeanuj opened this issue Dec 26, 2020 · 2 comments
Open

Weekly & Monthly Streaks? #11

oyeanuj opened this issue Dec 26, 2020 · 2 comments

Comments

@oyeanuj
Copy link

oyeanuj commented Dec 26, 2020

Hi @jonsamp, thank you for creating this excellent library!

I'm curious if you'd consider adding weekly or monthly streaks to this library at some point? I could see the summary and trackRecord method being updated to add those streaks as well.

The only other place I could find which did something similar (but now the library is unmaintained):
https://github.com/iancanderson/streaker-js/blob/7f5b4c79326a803d1200bf0eb9d4718d8e149695/src/streak_calculator.coffee#L54-L92

@jonsamp
Copy link
Owner

jonsamp commented Feb 25, 2021

I like this feature idea a lot. I'm currently pretty busy with work and other projects, but happy to review a PR for this feature. Alternatively, if you could define the test cases ("x" input produces "y" output), that would help me a lot in creating the logic to accomplish this.

Sorry for the late response, thanks for opening an issue!

@ghana7989
Copy link

Hi @jonsamp, thank you for creating this excellent library!

I'm curious if you'd consider adding weekly or monthly streaks to this library at some point? I could see the summary and trackRecord method being updated to add those streaks as well.

The only other place I could find which did something similar (but now the library is unmaintained):
https://github.com/iancanderson/streaker-js/blob/7f5b4c79326a803d1200bf0eb9d4718d8e149695/src/streak_calculator.coffee#L54-L92

Can You give an example, for what given input you want desired output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants