Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method for zygote.seed(::CA) #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add method for zygote.seed(::CA) #229

wants to merge 1 commit into from

Conversation

vpuri3
Copy link
Contributor

@vpuri3 vpuri3 commented Oct 25, 2023

fix #228

with this PR

julia> Zygote.hessian(x -> sum(x.a .* x.b), p)
4×4 Matrix{Float64}:
 0.0  0.0  1.0  0.0 
 0.0  0.0  0.0  1.0 
 1.0  0.0  0.0  0.0 
 0.0  1.0  0.0  0.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023 •
edited

Codecov Report

Merging #229 (534ccd8) into main (d22a56c) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   73.33%   72.76%   -0.57%     
==========================================
  Files          23       23              
  Lines         735      738       +3     
==========================================
- Hits          539      537       -2     
- Misses        196      201       +5
Files Coverage Δ
ext/ComponentArraysZygoteExt.jl 40.00% <0.00%> (-60.00%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vpuri3
Copy link
Contributor Author

vpuri3 commented Oct 30, 2023

@jonniedie

@jonniedie
Copy link
Owner

Would you mind throwing a test case in the autodiff tests with the Hessian example you showed? (And bumping the version number)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with Zygote.hessian
3 participants
@vpuri3 @codecov-commenter @jonniedie