This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Fix required error #278
Closed
Fix required error #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisvanmook
requested review from
chrisvanmook and
jonkoops
and removed request for
chrisvanmook
|
Hi @gky360. This is certainly a bug you have found. We're considering a new API design that will eliminate the need for passing a massive object with options and instead make individual calls to trigger these kind of options, see #176. I think your change is logical, but it would conflict with the work done in #236 to make these options required. I would recommend to wait until we roll out our new API which will probably be done a couple of weeks from now when we have some time to work on it. |
|
Thank you for checking the PR. I understand your policy on the new API. I'm looking forward to the new API to be released. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277.
Amsterdam styled components pull request
Before opening a pull request, please ensure:
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)