Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Gmail extensions #224

Open
CrispinStichart opened this issue Mar 28, 2022 · 6 comments
Open

Adding support for Gmail extensions #224

CrispinStichart opened this issue Mar 28, 2022 · 6 comments

Comments

@CrispinStichart
Copy link
Contributor

Gmail added a few non-standard extensions to the IMAP protocol, for handling labels and a few other things.

What's this project's stance on supporting non-standard extensions?

@jonhoo
Copy link
Owner

jonhoo commented Apr 2, 2022

I'm not against adding these in, probably behind a trait of some kind so that users have to explicitly say they want access to those methods. Or maybe better yet, through a

impl Session {
    fn gmail(&mut self) -> Option<GmailClientExtensions<'_>> {}
}

which returns None if the appropriate capability is present on the server.

@CrispinStichart
Copy link
Contributor Author

Okay, cool. I'll give it a shot. ^_^

@CrispinStichart
Copy link
Contributor Author

Well, that was easy -- it turns out that support for Gmail labels (which was the only thing I care about) was added to imap-proto a couple of months ago.

Unfortunately, they haven't made a release yet that includes those changes.

In the meantime, I forked rust-imap, switched the imap-proto dependency to pull from the git, and did what needed to be done: CrispinStichart@6e5ec17

You'll notice I deleted NameAttributes entirely, because imap-proto implemented that with this commit: djc/tokio-imap@4f60707

@jonhoo
Copy link
Owner

jonhoo commented Apr 5, 2022

@djc Any chance we could have a new imap-proto release with the label changes?

@djc
Copy link

djc commented Apr 6, 2022

I just published imap-proto 0.16 to crates.io.

@CrispinStichart
Copy link
Contributor Author

Thank, djc!

I made a pull request for this: #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants