Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conform to the Rust API guidelines #100

Open
jonhoo opened this issue Nov 23, 2018 · 1 comment
Open

Conform to the Rust API guidelines #100

jonhoo opened this issue Nov 23, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed tombstone A reference to an old issue on mattnenterprise/rust-imap
Milestone
3.0.0

Comments

@jonhoo
Copy link
Owner

jonhoo commented Nov 23, 2018 •
edited

While 0.9 made some significant improvements to the imap crates' interface, we still have some way to go. In particular, we should go through the Rust API guidelines checklist and do the best we can to match its recommendations. I think this is probably a blocker for 1.0.

See the original issue here: mattnenterprise/rust-imap#100
@jonhoo jonhoo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers tombstone A reference to an old issue on mattnenterprise/rust-imap labels Nov 23, 2018
@jonhoo jonhoo added this to the imap 1.0 milestone Nov 23, 2018
@jonhoo jonhoo mentioned this issue Nov 23, 2018
Closed
@jonhoo jonhoo modified the milestones: imap 1.0, 3.0.0 Apr 20, 2021
@OvermindDL1
Copy link

This won't help with API conformance, but it would help to ensure the API remains semver stable if added to github actions for example:

https://crates.io/crates/cargo-semver-checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed tombstone A reference to an old issue on mattnenterprise/rust-imap
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@jonhoo @OvermindDL1