Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async review #22

Open
SethDusek opened this issue Sep 10, 2019 · 1 comment
Open

Async review #22

SethDusek opened this issue Sep 10, 2019 · 1 comment

Comments

@SethDusek
Copy link

SethDusek commented Sep 10, 2019

Hi, since I need this crate for a project I'm working on, I decided to give implementing futures Stream for a BusReceiver (Bus sending isn't async in this patch), however I am curious as to whether this implementation is correct, since I'm not too experienced with lock-free code

lib.rs

Basically, if a value is not ready, it sends the current Waker (kind of equivalent of thread handle) to the unparking channel, which will wake it up when it's ready.

@jonhoo
Copy link
Owner

jonhoo commented Sep 10, 2019

I think @habnabit would be a good person to ping here, as they did a bunch of related work over in #15, culminating in https://github.com/habnabit/bus/tree/async_bus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants