Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea newUI not in effect #2

Closed
RuoBingCoder opened this issue Dec 7, 2022 · 20 comments
Closed

idea newUI not in effect #2

RuoBingCoder opened this issue Dec 7, 2022 · 20 comments
Labels
see youtrack.jetbrains.com Problem on JetBrains side. Please upvote the linked Youtrack issue, it would help. Thanks!

Comments

@RuoBingCoder
Copy link

Starting a new ui icon in idea 2022.3 does not take effect

@jonathanlermitage
Copy link
Owner

I think I will try to support the new UI, but for now there are some problems: the new UI uses new temporary icon IDs. These IDs will probably change when the new UI is finalized.
Also, I have to rework many icons. I tried to reuse some icons, but they don't fit well with the new UI.
Finally, some icon IDs simply changed. I will need some time in order to find the new IDs. So, yeah, I will try so support the new UI, but it represents a lot of work. Don't expect releases for the new UI until a few months.
As usual, contributions are highly appreciated. 😀

@SerVB
Copy link

SerVB commented Dec 27, 2022

I have the colorful icons sometimes shown in the new UI, but more frequently just default icons are shown. It's interesting that Gradle icon is colorful more often than other icons. After an IDE restart, icons stop being colorful.

For example, here, colorful icons are applied and they look awesome to me:

grafik

Is it expected?

@jonathanlermitage
Copy link
Owner

jonathanlermitage commented Dec 27, 2022

The plugin is expected to be stable (no crash or warnings), but since new icons ID may change on any IDE update... I cannot say which icons are supported for now. I think I will wait for the final release in order to find the definitive new icons ID, then I will update the plugin.
I may also have to rework some icons. Last time I tried support the new UI, some icons were too small, but they may fit better with the latest update... It could explain why icons look good on your machine.

@jonathanlermitage
Copy link
Owner

jonathanlermitage commented Dec 27, 2022

Hmm it's weird. I just tried IJ Community 2022.3.1, and the Terminal and Problem icons are not overridden... 😅
image

@LovePlayCode
Copy link

new ui not use icon

@LovePlayCode
Copy link

Sometimes it works and sometimes it doesn't

@jonathanlermitage
Copy link
Owner

Yeah, I will wait until the new UI has been finalized.

@LovePlayCode
Copy link

thanks

@jonathanlermitage
Copy link
Owner

Just for info, this is probably a bug in IntelliJ. I can do nothing for now 😅.
Please do not open new issues for that.

@EfourC
Copy link

EfourC commented Apr 4, 2023

Any idea if there is an open bug report on JetBrain's tracking system for this? I just looked at it for the first time and didn't find anything, but I could easily miss it and I'm not sure if there's special terminology relevant for plugin developers.
https://youtrack.jetbrains.com/issues/PY

I like your plugin, but am sadly stuck with the built-in monochrome outline style icons.

@jonathanlermitage
Copy link
Owner

I no longer find the existing issue... I will create a new one ^^

@PrettiestFairy
Copy link

I think I will try to support the new UI, but for now there are some problems: the new UI uses new temporary icon IDs. These IDs will probably change when the new UI is finalized. Also, I have to rework many icons. I tried to reuse some icons, but they don't fit well with the new UI. Finally, some icon IDs simply changed. I will need some time in order to find the new IDs. So, yeah, I will try so support the new UI, but it represents a lot of work. Don't expect releases for the new UI until a few months. As usual, contributions are highly appreciated. 😀

The plug-in is not compatible with the latest IDE version.

Occasionally, rebooting can solve it.

image
image

@jonathanlermitage jonathanlermitage added this to the 1.26 milestone May 10, 2023
@mguilherme
Copy link

It doesn't work on IntelliJ IDEA 2023.1.1 (Ultimate Edition)

@jonathanlermitage
Copy link
Owner

Submitted https://youtrack.jetbrains.com/issue/IDEA-321006/cant-override-IDE-SVG-icons-with-IconPathPatcher-in-newUI. Upvoting this Youtrack issue would help. Thanks!

@jonathanlermitage jonathanlermitage added the see youtrack.jetbrains.com Problem on JetBrains side. Please upvote the linked Youtrack issue, it would help. Thanks! label May 24, 2023
@PrettiestFairy
Copy link

@jonathanlermitage
If you see the information, please make an adaptation of pycharm

@jonathanlermitage
Copy link
Owner

jonathanlermitage commented Jul 13, 2023

@AceProfessional the fix for IntelliJ should also work for any IntelliJ based IDE, like PyCharm.
We simply have to wait for https://youtrack.jetbrains.com/issue/IDEA-321006/cant-override-IDE-SVG-icons-with-IconPathPatcher-in-newUI resolution.

@1104340845
Copy link

image
it seems to have been in effect.

@jonathanlermitage jonathanlermitage removed this from the 1.26 milestone Sep 11, 2023
@jonathanlermitage
Copy link
Owner

jonathanlermitage commented Sep 22, 2023

This issue seems to be fixed in IntelliJ 2023.3 EAP (#IC-233.6745.305, built on September 21, 2023) 🥳
Can you confirm?

@EfourC
Copy link

EfourC commented Sep 22, 2023

I can't speak for IntelliJ specifically, but it's been resolved in recent Pycharm versions, thanks!

PyCharm 2023.2.2 RC (Community Edition)
Build #PC-232.9921.36, built on September 11, 2023

@jonathanlermitage jonathanlermitage unpinned this issue Sep 22, 2023
@jonathanlermitage
Copy link
Owner

jonathanlermitage commented Sep 26, 2023

@jonathanlermitage jonathanlermitage pinned this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
see youtrack.jetbrains.com Problem on JetBrains side. Please upvote the linked Youtrack issue, it would help. Thanks!
Projects
None yet
Development

No branches or pull requests

8 participants