Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service used by layout module #672

Closed
bampakoa opened this issue Feb 22, 2016 · 3 comments
Closed

Service used by layout module #672

bampakoa opened this issue Feb 22, 2016 · 3 comments

Comments

@bampakoa
Copy link

In case you have to create a service that is used from the controller of the layout module (e.g. Shell) where would you add it? In the core service or in a dedicated one inside the layout module?

Thanks

@NevillePerkins
Copy link

Good question. I'm struggling with the same concept.

@andreshg112
Copy link
Contributor

I'm waiting for the answer too.

@bampakoa
Copy link
Author

While I am thinking it again and again, I conclude to the following:
Since the layout _is_ a module, everything that applies to the other modules should be valid for the layout also. Thus, the service should go to the layout module in that case. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants