Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if numeric version field is OK #160

Open
paulirish opened this issue Feb 4, 2020 · 0 comments
Open

Determine if numeric version field is OK #160

paulirish opened this issue Feb 4, 2020 · 0 comments

Comments

@paulirish
Copy link
Contributor

In Lighthouse we had some code the assumed the .version property on a discovered library would be a string. But in the Magento 2 case, it's a number literal.

We're now casting to a string, so we'll be fine, but I wanted to raise it here in case other consumers may make similar assumptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant