Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow tests not correctly identified with HHVM #17

Open
gui-com-pt opened this issue Mar 18, 2016 · 1 comment
Open

Slow tests not correctly identified with HHVM #17

gui-com-pt opened this issue Mar 18, 2016 · 1 comment

Comments

@gui-com-pt
Copy link

With HHVM 3.12.0:

........                                                            8 / 8 (100%)

You should really fix these slow tests (>50ms)...
 1. 3436ms to run PiHostTest:testCreatesContainer
 2. 45ms to run PiHostTest:testMessageFactoryIsSet
 3. 41ms to run PiHostTest:testAssertHostProviderInstanceIsSet
 4. 41ms to run PiHostTest:testCanRegisterPlugin
 5. 34ms to run PiHostTest:testSetAndGetCacheProvider
 6. 34ms to run PiHostTest:testEventManagerIsCreated
 7. 31ms to run PiHostTest:testAppSettingsIsRegistered
 8. 15ms to run PiHostTest:testExecuteRequestAndWriteResponse

Time: 22.49 seconds, Memory: 19.13Mb

OK (8 tests, 9 assertions)

If i set the limit to 50ms the only slow test from the above report shouldn't be the first?

I know that HHVM support isn't reference but i wanted to be sure as at this moment i'm in doubt if it's reporting the extra execution time from 50ms (50+3436, 50+45, etc) instead of the execution time itself.

@johnkary
Copy link
Owner

johnkary commented Feb 9, 2017

@guilhermegeek Yes, I never tested this with HHVM.

If a fix is ever found we could release a 1.0.2 tag, but v2.0 phpunit-speedtrap will not support HHVM. PHPUnit itself has dropped HHVM support via this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants