Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate plugin in favor output.clean #197

Open
alexander-akait opened this issue Feb 25, 2021 · 8 comments
Open

Deprecate plugin in favor output.clean #197

alexander-akait opened this issue Feb 25, 2021 · 8 comments

Comments

@alexander-akait
Copy link

webpack has built-in support for clearing stale assets https://webpack.js.org/configuration/output/#outputclean, so I think we can deprecate this plugin

@galvarez421
Copy link

I think output.clean does not clean the output directory when running webpack-dev-server, while this plugin seems to be able to.

@alexander-akait
Copy link
Author

@galvarez421 it should, what is the problem?

@vovkvlad
Copy link

@alexander-akait it seems like output.clean does not clean files for webpack dev server, and you confirmed that it is not supposed to in the issue I logged recently

webpack/webpack#12949

@alexander-akait
Copy link
Author

I strongly recommend use the writeToDisk option only for files to be read from fs. otherwise you lose performance

@yckbilly1929
Copy link

output.clean looks good
but not sure if it supports cleanAfterEveryBuildPatterns?

@alexander-akait
Copy link
Author

Why do you need cleanAfterEveryBuildPatterns? Can you describe use case?

@yckbilly1929
Copy link

Why do you need cleanAfterEveryBuildPatterns? Can you describe use case?

I'm currently using it to remove intermediate files like sourcemap, after pushed to sentry
maybe this is not the best practice, but suit the requirement

@alexander-akait
Copy link
Author

/cc @johnagan what do you think? Maybe we need some more options for fully replace this plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants