Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock files #180

Open
jneuendorf opened this issue Jun 23, 2020 · 1 comment
Open

Lock files #180

jneuendorf opened this issue Jun 23, 2020 · 1 comment

Comments

@jneuendorf
Copy link

Question

@chrisblossom Why did you decide not to use lock files (neither NPM nor Yarn) in this project? From what I've read those are a step forward (regarding dependency management). If there is a good reason (I'm sure you at least had a good reason) I'd really like to learn what it is! 🙂

@chrisblossom
Copy link
Collaborator

Both package-lock.json and yarn.lock should be used for applications (but only one).

In my opinion, libraries should not use lock files because the end user can (and will) end up with different dependencies since both npm and yarn ignore dependency lock files. So your library can seemingly pass tests, but be broken for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants