Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to preserve previous builds for maxAge seconds #192

Closed
wants to merge 3 commits into from

Conversation

Dattaya
Copy link

@Dattaya Dattaya commented Dec 14, 2020

Fixes #176, #3
@johnagan, @chrisblossom, I can think of three ways (there could be more) not preserving some of the recent builds might backfire:

  • someone's using a website during deployment and requests split chunks previously not loaded that are no longer there
  • if a dev decides to cache index.html with a service like Cloudflare, and a split chunk was not requested before and therefore not cached, and is now requested.
  • if there was not enough time to load everything, service worker would try to load the rest during the next visit?

It's still a draft because I don't know if you're interested and if I'm moving in the right direction. So far I save the list of assets from previous builds in a file, filename and path are configurable. preserve option is only handled on initial builds, should it work during watch rebuilds as well? Potential improvements:

  • allow preserve to be a number (maxAge) - could be confusing if in the future we decide to add nPreviousBuilds additional option alongside maxAge
  • remove duplicates from assetList with a Set - unless it does not improve performance of del

@Dattaya Dattaya closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPA: Lazy loading / code splitting components & code changes
1 participant