feat: allow to preserve previous builds for maxAge
seconds
#192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176, #3
@johnagan, @chrisblossom, I can think of three ways (there could be more) not preserving some of the recent builds might backfire:
index.html
with a service like Cloudflare, and a split chunk was not requested before and therefore not cached, and is now requested.It's still a draft because I don't know if you're interested and if I'm moving in the right direction. So far I save the list of assets from previous builds in a file,
filename
andpath
are configurable.preserve
option is only handled on initial builds, should it work duringwatch
rebuilds as well? Potential improvements:preserve
to be a number (maxAge
) - could be confusing if in the future we decide to addnPreviousBuilds
additional option alongsidemaxAge
assetList
with aSet
- unless it does not improve performance ofdel